[#23585] - [staging] Deleting unused Contacts "banned" fields
- Fixed in Code Base
- 1 Feb 2019
- Medium
- Build: staging
- # 23585
- Diff
- infograf768:contacts_unused_params
User tests: Successful: Unsuccessful:
Pull Request for Issue #23569
Summary of Changes
Deleting unused contact fields:
banned_email
banned_subject
banned_text
Keeping them in the Component Options as, since 2.5, it is the only place where they work.
Deprecating some ini strings
Corrected sql files
Modified some unit test files EXCEPT /tests/unit/stubs/database/jos_finder_links.csv which I have no idea how to clean.
For that one, @mbabker @wilsonge @Hackwar please make PR against mine
Testing Instructions
Edit a contact, a contact category, all contacts menu items and make sure the 3 fields do not appear.
Check the sql for possible errors.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Front End SQL Installation Postgresql MS SQL Unit Tests |
I have tested this item
- Contact fields under: components > contacts > contacts > mycontact:
banned_email
banned_subject
banned_text
are deleted.
-
In com_contacts Global Options it works - still working :-)
-
sql > sorry, don't know
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23585.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23585.
| Status | Pending | ⇒ | Ready to Commit |
Rtc
@maintainers please look at the file I did not correct, if it is still used.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23585.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23585.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-01 10:59:35 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
I have tested this item✅ successfully on 4f51528
- Contact fields under: components > contacts > contacts > mycontact > Form:
banned_email
banned_subject
banned_text
are deleted.
In com_contacts Global Options it works - still working :-)
sql > sorry, don't know
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23585.