PR-staging

Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jan 2019

The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article.

The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible.

Testing

Create a blog and a featured view
Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR)
You will now see the subheading in an h2 tag at the top of the page (below the page title if set)

I see this as a bug not a new feature as stated above

avatar brianteeman brianteeman - open - 18 Jan 2019
avatar brianteeman brianteeman - change - 18 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jan 2019
Category Front End com_content
avatar chmst
chmst - comment - 20 Jan 2019

I agree with this PR but would like to have a dependecy between show_title and subtitle (showon). In my opinion, a subtitle makes ony sense when there is a title.
And I agree that this is the same for categories - if there is no b/c reason, another PR could bring the field into the page display tab.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23583.

avatar brianteeman
brianteeman - comment - 20 Jan 2019

That is beyond the scope of this pr.

avatar brianteeman
brianteeman - comment - 21 Feb 2019

Adding that dependency would make it a new feature as there would be b/c issues

avatar HLeithner HLeithner - change - 22 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-22 08:37:47
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Feb 2019
avatar HLeithner HLeithner - merge - 22 Feb 2019
avatar HLeithner
HLeithner - comment - 22 Feb 2019

thx

avatar brianteeman
brianteeman - comment - 22 Feb 2019

Thanks

Add a Comment

Login with GitHub to post a comment