[#23583] - Featured articles page subheading
- Fixed in Code Base
- 22 Feb 2019
- Medium
- Build: staging
- # 23583
- Diff
- brianteeman:subheading
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
The featured articles view is intended to be identical to the blog view. The only differences are because it is not purely based on category selection but also on the featured attribute of an article.
The blog view has a page_subheading option but this is missing from the featured view. This PR adds the page_subheading to that view so that the two views are as consistent as possible.
Testing
Create a blog and a featured view
Add a page subheading - you will find the option in the menu. For featured it is at the bottom of the Layout tab. For blog it is at the bottom o the category tab (I think thats wrong but is beyond the scope of this PR)
You will now see the subheading in an h2 tag at the top of the page (below the page title if set)
I see this as a bug not a new feature as stated above
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
That is beyond the scope of this pr.
Adding that dependency would make it a new feature as there would be b/c issues
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-22 08:37:47 |
| Closed_By | ⇒ | HLeithner |
thx
Thanks
I agree with this PR but would like to have a dependecy between show_title and subtitle (showon). In my opinion, a subtitle makes ony sense when there is a title.
And I agree that this is the same for categories - if there is no b/c reason, another PR could bring the field into the page display tab.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23583.