Feeling Lucky
NPM Resource Changed
?
[#23426] - [4.0] Codemirror proper Custom Element
- Closed
- 2 Apr 2019
- Medium
- Build: 4.0-dev
- # 23426
- Diff
- dgrammatiko:4.0-dev-ce-codemirror
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Since we are already concatenating a bunch of files for the code mirror I've concatenated 2 more...
- The custom element is not using Async/Await as this will fail to anything older than current ver of Evergreen browsers
- The element is using correctly mutation observers
- Calling document API's in the connectedCallback NEVER in the constructor!!!
- Proper bindings
Testing Instructions
Apply patch, change browser to Code mirror and check if everything still works ok
Expected result
Actual result
Documentation Changes Required
No, this just moves the code closer to production
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Front End Plugins |
| Labels |
Added:
?
|
||
dgrammatiko
- comment
- 18 Feb 2019
@PhocaCz @infograf768 should be fine now
infograf768
- comment
- 18 Feb 2019
Drone is not happy. javascript-cs
/drone/src/github.com/joomla/joomla-cms/build/build-modules-js/javascript/compile-w-c.es6.js
74:116 error Missing semicolon semi
107:40 error Missing semicolon semi
✖ 2 problems (2 errors, 0 warnings)
2 errors and 0 warnings potentially fixable with the `--fix` option.
Concerning the patch, it is now working fine. :)
| Category | JavaScript Repository Front End Plugins | ⇒ | JavaScript NPM Change Repository Front End Plugins |
| Labels |
Added:
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-02 11:08:07 |
| Closed_By | ⇒ | dgrammatiko |
I have tested this item? unsuccessfully on c2ad19d
Did you mean "editor" instead of "browser"?
Testing now on Joomla! 4.0.0-alpha7-dev and get following results, see images:
Before patch
After patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23426.