[#23421] - [4.0] PR #21558 moved system-message outside if(empty) in layouts/joomla/system/message.php file
- Closed
- 29 Jun 2019
- Medium
- Build: 4.0-dev
- # 23421
- Diff
- pmleconte:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23420 .
Summary of Changes
Moved <div id="system-messsage"> back inside <?php if....>
Testing Instructions
With your WebBrowser DevTools, check that <div id="system-message"><div> is not displayed if no system message is to be displayed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Layout |
| Title |
|
||||||
| Title |
|
||||||
@bembelimen : I just put back the div where it was before pr #21558.
There is no need to display this div if no message has to be displayed. If you have an error message or a notice, it will be.
JS messages are injected in Media Manager so this will PR will not work.
To test, upload or delete a file. No alert shown.
const messageContainer = document.getElementById('system-message');
| Closed_Date | 2019-06-29 13:52:40 | ⇒ | 2019-06-29 13:52:42 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-29 13:52:40 |
| Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23421
Please always give a reason when you close something
I did. See my previous reply.
Did you check, if the JS errors (e.g. form submit in the frontend) still works? If I remember correctly, the JS messages will be injected into this div...