[#23420] - [4.0] PR #21558 moved system-message outside if (!empty) in layouts/joomla/system/message.php file
- Closed
- 1 Jan 2019
- Medium
- Build: staging
- # 23420
Steps to reproduce the issue
In #21558, file layouts/joomla/system/message.php has been updated and <div id="system-message> has been moved outside of its "if !empty($msgList) test (lines 27/28 and 41/42.
If no system has to be displayed an empty
is displayed.If your template has some CSS codes to customize #system-message behaviour, it will be displayed, even if it is unnecessary (empty).
Expected result
Do not display empty #system-message div
Actual result
Display an empty #system-message div
System information (as much as possible)
Joomla 4.0
PHP 7.2.7
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-01 16:58:29 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23420
See PR #23421
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23420.
The container should always be rendered on the page to allow it to be targeted by the JavaScript API.
Hi Michael,
The container is <div id="system-message-container"> and not <div id="system-message">. If no message has to be displayed, there no need to display this extra div. That was working like this prior #21558.
Happy new year,
Pascal
The container should always be rendered on the page to allow it to be targeted by the JavaScript API.