Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23413] - [4.0] Eliminate jQuery from Modal footer

? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
31 Dec 2018

Pull Request for Issue # .

Summary of Changes

  • Adds one more helper function in core.js: Joomla.iframeButtonClick()
  • Function accepts object:
{
iframeSelector: 'Some_css_selectror_or_id_of_the_iframe_parent',
buttonSelector: 'Some_css_selectror_or_id_of_the_button_in_the_iframe'
}
  • Why object? It's easier to do changes without breaking B/C!!!

Testing Instructions

Go to the admin area, system ->plugins and disable the redirects plugin
Go to components->redirects
There will be an alert with a link, click on the link
Click the buttons close, save, save and close and observe that everything works fine.

Code review the rest

Expected result

Actual result

Documentation Changes Required

Yes, for the devs not for the users

avatar dgrammatiko dgrammatiko - open - 31 Dec 2018
avatar dgrammatiko dgrammatiko - change - 31 Dec 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Dec 2018
Category ⇒ Administration com_banners com_csp com_menus com_messages com_redirect JavaScript Repository Layout
avatar wilsonge
wilsonge - comment - 31 Dec 2018

@dgrammatiko can you fix the linting please :)

62ac9de 31 Dec 2018 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 31 Dec 2018
Labels Added: ? ?
avatar wilsonge wilsonge - change - 1 Jan 2019
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-01-01 20:30:37
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 1 Jan 2019
avatar wilsonge wilsonge - merge - 1 Jan 2019
avatar wilsonge
wilsonge - comment - 1 Jan 2019

Thanks :)

Add a Comment

Login with GitHub to post a comment