? ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
29 Dec 2018

Pull Request for Issue # .

Summary of Changes

  • This button is not used anywhere in the core
  • This button was based on mootools and mootools are not here anymore
  • This PR drops that button!!!
  • Javascript code was wrongly appended in shown.js
  • That code is now deleted
  • Classmap updated

Testing Instructions

Slider was not used anywhere in the core anyways so code review is what is needed here

Expected result

Actual result

Documentation Changes Required

This is a B/C break and needs to be documented and also communicated!!!!

avatar dgrammatiko dgrammatiko - open - 29 Dec 2018
avatar dgrammatiko dgrammatiko - change - 29 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Dec 2018
Category JavaScript Repository Layout Libraries
avatar Quy
Quy - comment - 29 Dec 2018

Add deleted files to the list in administrator/components/com_admin/script.php?

avatar Hackwar
Hackwar - comment - 30 Dec 2018

May I ask what this button did? Would we need something like this again? Somehow I had an input element of type "range" in my mind when reading this, but as a button? Anyway, good that you are removing this stuff. 😉 I don't think that you have to add any files to the deleted files list, since that most likely has to happen by script shortly before we go to RC.

avatar Hackwar
Hackwar - comment - 30 Dec 2018

I have tested this item ✅ successfully on cc38f14

Tested by codereview


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

avatar Hackwar Hackwar - test_item - 30 Dec 2018 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 30 Dec 2018

@Hackwar by translating the js part <div class="collapse fade" id="collapse-${name}"><iframe class="iframe" src="${url}" height="${height}" width="100%"></iframe></div> I think this was acting like an accordion kinda thingy. So when someone was clicking on that button then the container would expand and the iframe would be rendered inside.

avatar Quy
Quy - comment - 30 Dec 2018

It is my understanding that the list is for when upgrading to handle deleted files.

avatar mbabker
mbabker - comment - 30 Dec 2018

Someone can run https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php and build a full list of files at an appropriate time. Since the entire upgrade process is messed up right now, no point in randomly adding files to that list in random PRs; enforce it after everything is caught up.

avatar bonzani
bonzani - comment - 5 Jan 2019

I have tested this item ✅ successfully on cc38f14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

avatar bonzani bonzani - test_item - 5 Jan 2019 - Tested successfully
avatar Quy Quy - change - 5 Jan 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.

avatar wilsonge wilsonge - change - 15 Jan 2019
Labels Added: ?
avatar rdeutz rdeutz - change - 19 Jan 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 26 Jan 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-05 23:51:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Feb 2019
avatar wilsonge wilsonge - merge - 5 Feb 2019
avatar wilsonge
wilsonge - comment - 5 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment