User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue # .
Slider was not used anywhere in the core anyways so code review is what is needed here
This is a B/C break and needs to be documented and also communicated!!!!
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository Layout Libraries |
May I ask what this button did? Would we need something like this again? Somehow I had an input element of type "range" in my mind when reading this, but as a button? Anyway, good that you are removing this stuff.
I have tested this item
Tested by codereview
@Hackwar by translating the js part <div class="collapse fade" id="collapse-${name}"><iframe class="iframe" src="${url}" height="${height}" width="100%"></iframe></div>
I think this was acting like an accordion kinda thingy. So when someone was clicking on that button then the container would expand and the iframe would be rendered inside.
It is my understanding that the list is for when upgrading to handle deleted files.
Someone can run https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php and build a full list of files at an appropriate time. Since the entire upgrade process is messed up right now, no point in randomly adding files to that list in random PRs; enforce it after everything is caught up.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-05 23:51:15 |
Closed_By | ⇒ | wilsonge |
Thanks!
Add deleted files to the list in
administrator/components/com_admin/script.php
?