Joomla! Issue Tracker | Joomla! CMS #23388 - [4.0] fix a todo, drop the slider button

? ? ?

Fixed in Code Base
5 Feb 2019
Medium
Build: 4.0-dev
# 23388
Diff
dgrammatiko:4.0-dev-fix-todo

Pending

User tests: Successful: 0 Unsuccessful: 0

dgrammatiko
29 Dec 2018

Pull Request for Issue # .

Summary of Changes

This button is not used anywhere in the core
This button was based on mootools and mootools are not here anymore
This PR drops that button!!!
Javascript code was wrongly appended in shown.js
That code is now deleted
Classmap updated

Testing Instructions

Slider was not used anywhere in the core anyways so code review is what is needed here

Expected result

Actual result

Documentation Changes Required

This is a B/C break and needs to be documented and also communicated!!!!

53a40bf 29 Dec 2018

fix the todo

cc38f14 29 Dec 2018

Merge branch '4.0-dev' of github.com:joomla/joomla-cms into 4.0-dev-fix-todo

dgrammatiko - open - 29 Dec 2018

dgrammatiko - change - 29 Dec 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 29 Dec 2018

Category

⇒

JavaScript Repository Layout Libraries

Quy - comment - 29 Dec 2018

Add deleted files to the list in administrator/components/com_admin/script.php?

Hackwar - comment - 30 Dec 2018

May I ask what this button did? Would we need something like this again? Somehow I had an input element of type "range" in my mind when reading this, but as a button? Anyway, good that you are removing this stuff. ? I don't think that you have to add any files to the deleted files list, since that most likely has to happen by script shortly before we go to RC.

Hackwar - comment - 30 Dec 2018

I have tested this item ✅ successfully on cc38f14

Tested by codereview

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23388.}

Hackwar - test_item - 30 Dec 2018 - Tested successfully

dgrammatiko - comment - 30 Dec 2018

@Hackwar by translating the js part <div class="collapse fade" id="collapse-${name}"><iframe class="iframe" src="${url}" height="${height}" width="100%"></iframe></div> I think this was acting like an accordion kinda thingy. So when someone was clicking on that button then the container would expand and the iframe would be rendered inside.

Quy - comment - 30 Dec 2018

It is my understanding that the list is for when upgrading to handle deleted files.

mbabker - comment - 30 Dec 2018

Someone can run https://github.com/joomla/joomla-cms/blob/4.0-dev/build/deleted_file_check.php and build a full list of files at an appropriate time. Since the entire upgrade process is messed up right now, no point in randomly adding files to that list in random PRs; enforce it after everything is caught up.