Feeling Lucky
?
[#23381] - Fix javascript lint
- Fixed in Code Base
- 29 Dec 2018
- Medium
- Build: 4.0-dev
- # 23381
- Diff
- wilsonge:fix/javascript-lint
User tests: Successful: Unsuccessful:
Fixes errors in js lint
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
dgrammatiko
- comment
- 29 Dec 2018
The html in the literals is way off: no closing div and the buttons don't have a type...
Fail
zero-24
- comment
- 29 Dec 2018
@SniperSister @zero-24 rips please
@wilsonge please point me to the issue? Rips looks green for me?
wilsonge
- comment
- 29 Dec 2018
No worries. It failed before I rebased on j4 with 11 errors (http://ci.joomla.org/joomla/joomla-cms/13185) but if it works now i guess all good
wilsonge
- comment
- 29 Dec 2018
The html in the literals is way off: no closing div and the buttons don't have a type...
I know but you've got that fixed in your PR. this allows us to merge things and get the tests running whilst your more comprehensive js changes get tested
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-29 00:42:39 |
| Closed_By | ⇒ | wilsonge |
@SniperSister @zero-24 rips please