? ? ? Error

User tests: Successful: Unsuccessful:

avatar andrewnester
andrewnester
25 Oct 2013

JCryptTest cases for testing encrypting, decrypting, setting key and generating key
Link to JoomlaCode Tracker http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32423&start=0

avatar andrewnester andrewnester - open - 25 Oct 2013
avatar elinw
elinw - comment - 6 Nov 2013

That's fantastic thanks.

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
Build ,
avatar nicksavov nicksavov - change - 16 Oct 2014
Title
JCryptTest cases for testing encrypting, decrypting, setting and generating key
[#32423] JCryptTest cases for testing encrypting, decrypting, setting and generating key
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Unit Tests
avatar brianteeman brianteeman - change - 17 Oct 2014
Title
[#32423] JCryptTest cases for testing encrypting, decrypting, setting and generating key
JCryptTest cases for testing encrypting, decrypting, setting and generating key
avatar Hackwar
Hackwar - comment - 17 Nov 2014

Could you please fix the codestyle issues and update this to the latest version of staging? Also, please look over the tests again. There is for example no check for the return value of decrypt().

avatar rdeutz
rdeutz - comment - 19 Nov 2014

These test are not testing so much of the class, I would close this PR. Further more at the testing code sprint we removed all the placeholder test code because we have had a lot of needs to be implemented "test", so this PR can't be merged anyway.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2338.

avatar Bakual
Bakual - comment - 19 Nov 2014

Closing based on comments.
Thanks for your contribution anyway. If you want to propose a updated and more complete unit test, feel free to create a new PR.

avatar Bakual Bakual - close - 19 Nov 2014
avatar Bakual Bakual - change - 19 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-19 16:35:15
avatar Bakual Bakual - change - 19 Nov 2014
Title
JCryptTest cases for testing encrypting, decrypting, setting and generating key
[#32423] JCryptTest cases for testing encrypting, decrypting, setting and generating key

Add a Comment

Login with GitHub to post a comment