[#23289] - [4.0] Admin modules: Cannot select or filter by position
- Fixed in Code Base
- 4 Jan 2019
- Medium
- Build: 4.0-dev
- # 23289
- Diff
- infograf768:4-0.admin_modules_position
User tests: Successful: Unsuccessful:
#22263 forgot admin modules
Summary of Changes
Change type of the position field for admin modules.
Setting the correct client id.
Testing Instructions
Install j4 from 4.0-dev or nightly.
Display Administrator Modules Manager
Create or edit one these modules.
Note: there are other errors
Expected result
The Position field should be similar to the one used for Site Modules, i.e. letting clear, select, set to None the position.
Filtering by position should display the administrator template positions
Actual result
For the manager, positions are sometimes the ones from the frontend template in the filter
Editing the admin module displays a simple field
After patch
Note
There are other errors, not only related to admin modules.
- The calendar icons are showing over the position dropdown (see image above)
- After filtering in the manager by anything else than Select and clicking anywhere on the page, the filter fields are displayed horizontally on the page, hiding some items.
General Comment
The decision to take off from the Modules Manager the Site/Admin filter is at the origin of some issues concerning userstate and filters specially when a user switches from one to the other via the menu or System CPanel.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Labels |
Added:
?
|
||
The calendar icons are showing over the position dropdown
that is CSS issue, somewhere, I tried to fix it in https://github.com/joomla/joomla-cms/pull/22263/files#diff-712f8768cba688c1b024f23f9941f51eR4 not sure why it there again
@Fedik
If we use the code in 3.9.0 from @SharkyKZ then indeed we just have to modify the way to get the $clientId in ModulesPositioneditField.php by using getUserState('com_modules.modules.client_id', 0, 'int')
Concerning the dropdown z-index, it looks like .choices__list--dropdown in template.css is loaded BEFORE the /media/vendor/choicesjs/css/choices.css and is therefore overriden by that file. (Debug on).
So we get
.choices__list--dropdown {
display: none;
z-index: 1;
position: absolute;
width: 100%;
background-color: #FFFFFF;
border: 1px solid #DDDDDD;
top: 100%;
margin-top: -1px;
border-bottom-left-radius: 2.5px;
border-bottom-right-radius: 2.5px;
overflow: hidden;
word-break: break-all;
}
and z-index = 1; instead of 10
That should work. Just don't add 3rd argument to getUserState(). I added it by mistake. Oops.
Modified to use getUserState
Please test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-04 18:35:57 |
| Closed_By | ⇒ | wilsonge |
Thanks guys!
Is this not the same as #22040? At least the filter part.