? ? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Dec 2018

ENSURE THIS IS MERGED AS A MERGE COMMIT - DO NOT SQUASH AND MERGE TO ALLOW ME TO BE ABLE TO FIX CONFLICTS BETWEEN J3.X AND J4

avatar wilsonge wilsonge - open - 16 Dec 2018
avatar wilsonge wilsonge - change - 16 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Dec 2018
Category Repository Administration com_admin SQL Postgresql com_categories com_finder com_media com_menus com_users Language & Strings JavaScript Front End com_contact com_content com_search com_tags External Library Composer Change Installation
avatar wilsonge wilsonge - change - 16 Dec 2018
Labels Added: ? ? ? ?
avatar wilsonge wilsonge - change - 16 Dec 2018
The description was changed
avatar wilsonge wilsonge - edited - 16 Dec 2018
avatar wilsonge
wilsonge - comment - 16 Dec 2018

@rdeutz need you (or someone in the test team) to look at drone here ASAP please. As far as I'm concerned the only thing that's changed versions here is codemirror. Everything else is just http/https stuff

avatar rdeutz
rdeutz - comment - 16 Dec 2018

it fails because of the node update, we need to add [CLEAR CACHE] to a commit message to clean the cache hopeing the old sass bindung are deleted too.

avatar wilsonge wilsonge - change - 16 Dec 2018
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 16 Dec 2018

Doesn't seem like that worked

avatar rdeutz
rdeutz - comment - 16 Dec 2018

http://ci.joomla.org/joomla/joomla-cms/12930 worked till the security analysis otherwise it seems ok to me.
@SniperSister or @zero-24 can you have a look?

avatar zero-24
zero-24 - comment - 16 Dec 2018

Rebooted drone as i have white listed the false positives; http://ci.joomla.org/joomla/joomla-cms/12931

avatar zero-24
zero-24 - comment - 16 Dec 2018

Drone & rips are happy now.

avatar rdeutz
rdeutz - comment - 16 Dec 2018

Thanks @zero-24, what now @wilsonge should I merge it?

avatar wilsonge wilsonge - change - 16 Dec 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-16 18:52:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Dec 2018
avatar wilsonge wilsonge - merge - 16 Dec 2018
avatar wilsonge
wilsonge - comment - 16 Dec 2018

Perfect! Thankyou :)

Add a Comment

Login with GitHub to post a comment