Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23278] - [Regression] Make a redirection optional for the menu item alias

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
12 Dec 2018

Pull Request for Issue #22432 (comment)

Summary of Changes

Restore the default behaviour of the menu item alias to Joomla before version 3.9

Redirection is now optional and will not work on POST request.

Testing Instructions

See comments at #22432

Expected result

See comments at #22432

Actual result

See comments at #22432

Documentation Changes Required

New language strings.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar csthomas csthomas - open - 12 Dec 2018
avatar csthomas csthomas - change - 12 Dec 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2018
Category ⇒ Administration com_menus Language & Strings Libraries
avatar csthomas csthomas - change - 12 Dec 2018
Labels Added: ? ?
avatar sanderpotjer
sanderpotjer - comment - 12 Dec 2018

I have tested this item ✅ successfully on f354ab3

@csthomas great, thanks a lot! I confirm this is restoring the "old" behaviour, and makes the redirect optional. Template style is hiding nicely when redirect is set to Yes.

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar sanderpotjer
sanderpotjer - comment - 12 Dec 2018

I have tested this item ✅ successfully on f354ab3

@csthomas great, thanks a lot! I confirm this is restoring the "old" behaviour, and makes the redirect optional. Template style is hiding nicely when redirect is set to Yes.

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar sanderpotjer sanderpotjer - test_item - 12 Dec 2018 - Tested successfully
avatar csthomas
csthomas - comment - 13 Dec 2018

I have changed the order of conditions in the if statement so that I do not check the type of request in all requests.

avatar phproberto
phproberto - comment - 13 Dec 2018

I have tested this item ✅ successfully on 83de6dd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar phproberto phproberto - test_item - 13 Dec 2018 - Tested successfully
avatar sanderpotjer
sanderpotjer - comment - 13 Dec 2018

I have tested this item ✅ successfully on 83de6dd

Also after the latest commit, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar sanderpotjer
sanderpotjer - comment - 13 Dec 2018

I have tested this item ✅ successfully on 83de6dd

Also after the latest commit, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar sanderpotjer sanderpotjer - test_item - 13 Dec 2018 - Tested successfully
avatar infograf768 infograf768 - change - 13 Dec 2018
Status Pending ⇒ Ready to Commit
Labels
avatar infograf768
infograf768 - comment - 13 Dec 2018

RTC after 2 good tests.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278.

avatar csthomas
csthomas - comment - 17 Dec 2018

I have created one more PR (#23294) to allow 3rd party extensions/custom code to create a SEF url for alias links (menu item alias)

avatar mbabker mbabker - change - 18 Dec 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-12-18 02:40:29
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Dec 2018
avatar mbabker mbabker - merge - 18 Dec 2018

Add a Comment

Login with GitHub to post a comment