Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#23277] - [4.0][a11y]Admin module logged button

? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
12 Dec 2018

It is a a11y issue if links are used instead of buttons.

Summary of Changes

In admin module mod_logged, the button to log out a user is now a button, not a link.
It is implemented as a form.

Testing Instructions

You must have at least one - or better several - user(s) logged in in frontend.
Open the cpanel, the logged_in users are visible and each of them has a "logout" button.
Have a look in the sourcecode and control this via axe and with keyboard and screenreader.

Expected result

The buttons are accessible. When the admin activates one of the buttons, the respective user is logged out in the frontend.

Actual result

The buttons is a link with role="button" and therefore not a11y. When the administrator activates one of the buttons, the respective user is logged out in the frontend.

Documentation Changes Required

no

avatar chmst chmst - open - 12 Dec 2018
avatar chmst chmst - change - 12 Dec 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2018
Category ⇒ Modules Administration
avatar SharkyKZ
SharkyKZ - comment - 12 Dec 2018

Remove helper code related to logoutLink? Or use it in form action?

joomla-cms/administrator/modules/mod_logged/Helper/LoggedHelper.php

Lines 62 to 67 in 96bcefc

$results[$k]->logoutLink = '';
if ($user->authorise('core.manage', 'com_users'))
{
$results[$k]->editLink = Route::_('index.php?option=com_users&task=user.edit&id=' . $result->id);
$results[$k]->logoutLink = Route::_('index.php?option=com_login&task=logout&uid=' . $result->id . '&' . Session::getFormToken() . '=1');

avatar chmst chmst - change - 13 Dec 2018
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 13 Dec 2018

Previous commit removed too much code. Only need to remove 2 lines containing logoutLink.

avatar zwiastunsw
zwiastunsw - comment - 15 Jan 2019

I have tested this item ✅ successfully on a1a7911

Accessibility: OK
In my opinion, there is no need for an X sign. Unnecessary piece of code. It does not bring any new information.
PS. Shouldn't there be a "Force logout" label?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23277.

avatar zwiastunsw zwiastunsw - test_item - 15 Jan 2019 - Tested successfully
avatar chmst
chmst - comment - 15 Jan 2019

@zwiastunsw could you repeat the test?
I agree with your proposal to remove the icon,.
But at the moment I do not want to add another Language Key to the system.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23277.

avatar fancyFranci
fancyFranci - comment - 16 Jan 2019

I have tested this item ✅ successfully on 9abdc05

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23277.

avatar fancyFranci fancyFranci - test_item - 16 Jan 2019 - Tested successfully
avatar rdeutz rdeutz - change - 29 Jan 2019
Status Pending ⇒ Ready to Commit
avatar rdeutz
rdeutz - comment - 29 Jan 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23277.

avatar rdeutz rdeutz - change - 29 Jan 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-01-29 22:27:58
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 29 Jan 2019
avatar rdeutz rdeutz - merge - 29 Jan 2019

Add a Comment

Login with GitHub to post a comment