PR-staging ?

Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Dec 2018

Pull Request for Issue #23249

Summary of Changes

Adding hyphens to allowed characters in file names uploaded by drag and drop in TinyMCE.

Normalizing file names in direct com_media upload files to fit with the drag and drop format:

  1. the name of a file should not contain any period . before the extension.
    (real original name of these files are of the type: Screen Shot 2018-12-09 at 07.43.58.png on my Mac)
    This is nicely taken care of when drag and drop as periods are replaced by nothing (after adding the hyphen in the code above).
    Screen_Shot_2018-12-09_at_075108.png
    BUT not in normal upload where I get:
    Screen-Shot-2018-12-10-at-09.29.49.png

  2. Also, spaces are replaced by hyphens in one case and by underscores in the other.

Testing Instructions

Upload a file (usually an image) containing spaces and periods in other place than before the extension, both using com_media and drag and drop.

After patch

An image which name on the desktop is
Screen Shot 2018-12-09 at 07.43.58.png

will be uploaded to Joomla as
Screen_Shot_2018-12-09_at_074358.png

avatar infograf768 infograf768 - open - 10 Dec 2018
avatar infograf768 infograf768 - change - 10 Dec 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2018
Category Administration com_media
avatar infograf768 infograf768 - change - 10 Dec 2018
Title
com_media: normalizing file names
com_media: normalizing uploaded file names
avatar infograf768 infograf768 - edited - 10 Dec 2018
avatar infograf768 infograf768 - change - 10 Dec 2018
The description was changed
avatar infograf768 infograf768 - edited - 10 Dec 2018
36ec8ea 11 Dec 2018 avatar infograf768 cs
avatar infograf768 infograf768 - change - 11 Dec 2018
Labels Added: PR-staging
avatar Quy
Quy - comment - 20 Dec 2018

I have tested this item successfully on 36ec8ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.

avatar Quy Quy - test_item - 20 Dec 2018 - Tested successfully
avatar viocassel
viocassel - comment - 24 Dec 2018

I have tested this item successfully on 36ec8ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.

avatar viocassel viocassel - test_item - 24 Dec 2018 - Tested successfully
avatar infograf768 infograf768 - change - 24 Dec 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 24 Dec 2018

Thanks for testing. RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.

avatar mbabker mbabker - change - 27 Dec 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-12-27 19:02:51
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Dec 2018
avatar mbabker mbabker - merge - 27 Dec 2018

Add a Comment

Login with GitHub to post a comment