[#23259] - com_media: normalizing uploaded file names
- Fixed in Code Base
- 27 Dec 2018
- Medium
- Build: staging
- # 23259
- Diff
- infograf768:media_filename
User tests: Successful: Unsuccessful:
Pull Request for Issue #23249
Summary of Changes
Adding hyphens to allowed characters in file names uploaded by drag and drop in TinyMCE.
Normalizing file names in direct com_media upload files to fit with the drag and drop format:
-
the name of a file should not contain any period
.before the extension.
(real original name of these files are of the type:Screen Shot 2018-12-09 at 07.43.58.pngon my Mac)
This is nicely taken care of when drag and drop as periods are replaced by nothing (after adding the hyphen in the code above).
Screen_Shot_2018-12-09_at_075108.png
BUT not in normal upload where I get:
Screen-Shot-2018-12-10-at-09.29.49.png -
Also, spaces are replaced by hyphens in one case and by underscores in the other.
Testing Instructions
Upload a file (usually an image) containing spaces and periods in other place than before the extension, both using com_media and drag and drop.
After patch
An image which name on the desktop is
Screen Shot 2018-12-09 at 07.43.58.png
will be uploaded to Joomla as
Screen_Shot_2018-12-09_at_074358.png
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Title |
|
||||||
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing. RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-27 19:02:51 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 36ec8ea
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23259.