User tests: Successful: Unsuccessful:
Add gradient for background at the login screen for IE10
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=32295
I was thinking about that to, but when you use closest-side the layout doens'nt compare with the layout in Google Chrome, FireFox etc.
I think farthest-corner (this is default), works better
see this: http://www.w3schools.com/css/tryit.asp?filename=trycss3_gradient-radial_size
The only thing to consider here is that we are making changes to our Bootstrap files. It may be an appropriate fix, but sure would need a comment indicating that we made a change in a file coming from an external source.
Or you could do that same fix only for the isis template in the administrator/templates/isis/less/template.less file.
Bootstrap has noticed this bug also, see this pull request:
twbs/bootstrap#7462
I can add these line to the template.less file, but the radial gradient is defined over here. I think when you only edit the template.less file the bug isn't solve for other gradients maked with less
I think it would be fine if you add a comment line like https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/bootstrap.less#L65 You can also reference the Bootstrap PR there.
This way it's easier to track changes we made to these files.
Something like this? (i maked the chances also in the template.css, but that file will be overriden with the next build process when they compile the .less file)
Looks good to me, thanks!
Should be fine.
Since we build the CSS files from LESS files, this will be the wrong place to do that. You will have to make this change in the proper LESS file and run
build/generatecss.php
to compile the CSS files.Looking at it, this particular rule is generated by the
radial
mixin coming from Bootstrap itself (media/jui/less/mixins.less).