[#2320] - Redoing #2319
- Closed
- 24 Oct 2013
- Medium
- Build: master
- # 2320
- Diff
- wilsonge:patch-6
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Yeah just posted about this in the JBS skype - I'm not 100% sure how to do it as looking back at it - this guys PR seems to be changing bootstrap core. So I'm not sure whether we should be editing bootstrap - or override the line in question in less - which is less efficient css
Only override core Bootstrap if it's absolutely needed for everything in the CMS to work properly. Thus far, unless I'm mistaken, we're only doing that for JS, and everything else we're doing with the less efficient declaring of new CSS rules to override the core rules.
Only override in RTL less file (if needed), and use "php tools/generatecss.php" to generate automatically the CSS file, then add both to your PR. Never touch CSS with an editor.
Do not touch core bootstrap.
kk sweet. will do that now then
JM has committed correct version. Closing
George you need to patch the less file as well