? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Nov 2018

Pull Request for Issue #23164

Summary of Changes

The db_prefix input has to be proposed as ltr and text align to the right to be able to install Joomla when choosing an RTL language.
Otherwise we get an error

Plus a small correction of margins for the headers

Testing Instructions

See #23164 to use Persian
OR just modify installation/language/en-GB.xml to rtl 1

Before patch

Using en-GB.xml set as rtl

screen shot 2018-11-30 at 10 53 17

After patch

Joomla installs normally

@wilsonge

avatar infograf768 infograf768 - open - 30 Nov 2018
avatar infograf768 infograf768 - change - 30 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Nov 2018
Category Installation
avatar infograf768
infograf768 - comment - 30 Nov 2018

@wilsonge
There are other modifications to do in this rtl scss file as we have multiple instances of text-align: right; which could be avoided by just adding it to body. Also this would solve the alert title position.
I will take care of that in another PR

avatar wilsonge wilsonge - change - 30 Nov 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-30 11:33:52
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 30 Nov 2018
avatar wilsonge wilsonge - merge - 30 Nov 2018
avatar wilsonge
wilsonge - comment - 30 Nov 2018

Thanks JM

Add a Comment

Login with GitHub to post a comment