[#23207] - basic support for tags in com_banners
- Closed
- 20 Jul 2019
- Medium
- Build: staging
- # 23207
- Diff
- okonomiyaki3000:tagged-banners
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds basic support for tagging banners. The banner form will have a tags field which should work exactly like the tags field for other content-types.
It may be necessary to add a few more tag-related features to this (searching, etc.) before merging it but I'm putting in the PR now to hopefully get some feedback. I don't see any harm in adding tags to banners and there can surely be some benefits to it. However, since banners has been without tag support until now, I wonder if there could have been some reason other than simple oversight or disinterest. So I want to know, is this or is this not doable? Are there any potential problems to be aware of?
If it looks like there's no issue, I'll go ahead and complete this PR.
Testing Instructions
Create or edit a banner. Add or remove tags. Save it.
Expected result
Tags should be saved along with your banner.
Actual result
Works for me.
Documentation Changes Required
Maybe?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
This will need special handling in
com_tagsandmod_tags_similarbecause banner doesn't have frontend view. So we can't link to it.
And I'm fairly sure that's why tags support was never added to com_banners in the first place. This isn't saying having it isn't possible, but it does mean we need to think about the integration for a content type that doesn't actually have its own frontend.
I'll think about how we might handle that. Because I do think there are some good reasons to want to tag banners.
Because I do think there are some good reasons to want to tag banners.
Maybe start with writing some of them. Because honestly I don't see any right now (doesn't mean there aren't).
If we know what you want to achieve, then the implementation can follow.
closed due the lack of response.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-20 08:23:24 |
| Closed_By | ⇒ | franz-wohlkoenig |
This will need special handling in
com_tagsandmod_tags_similarbecause banner doesn't have frontend view. So we can't link to it.