[#23169] - [4.0] Custom Elements fix - editor none
- Fixed in Code Base
- 9 Dec 2018
- Medium
- Build: 4.0-dev
- # 23169
- Diff
- dgrammatiko:4.0-dev-CE-fix-editor-none
User tests: Successful: Unsuccessful:
Pull Request for Issue https://twitter.com/jaffathecake/status/1011214372696395777.
Summary of Changes
TL;DR
The web is a streaming media thus chunks of code served from the server might contain elements partially thus it shouldn't be assumed that the browsers will render the custom elements with all their childrens nodes synchronously. We overcome this by setting an observer to watch the state of the child nodes.
Testing Instructions
Apply this patch, change the editor to none and ensure that everything still works as before
Also you can check the lazy loading of the textarea element (what this PR is fixing) here:
https://codepen.io/dgrammatiko/pen/pQKjeR
Expected result
Custom element work in an async mode
Actual result
Custom element works only in a synchronous mode
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Title |
|
||||||
| Labels |
Added:
?
|
||
@dgrammatiko looks like this combined with your babel minifying code has broken drone. Can you please investigate :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-09 23:48:13 |
| Closed_By | ⇒ | wilsonge |
Thanks :)
I have tested this item✅ successfully on 0543bd4
Editor none still works after patch in com_content (and tested media, page break and article quick icons successfully)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23169.