[#23158] - [4.0] npm build tools update
- Fixed in Code Base
- 9 Dec 2018
- Medium
- Build: 4.0-dev
- # 23158
- Diff
- dgrammatiko:4.0-build-tools
User tests: Successful: Unsuccessful:
Pull Request for Issue none.
Summary of Changes
- Use the latest babel
- Use one and only one way to transpile ES-xxxx files
- Refactor and modularise
- Update ALL the dev dependencies
- Drop copying the es6 files in the media folder (until there is a way to utilise these files their presence in the media folder is useless)
Testing Instructions
- npm install should recreate the media folder correctly
- all the other npm commands in the package.json should give the exact same results (mind the drop of the es6 files)
Expected result
Actual result
Documentation Changes Required
From a functionality point of view there is nothing added to be documented.
PS. This is the first of multiple PRs but I'll try to make these in small chunks of code so ppl can review/test. Also I need a solid foundation to fix my own clasterf**k with the custom broken elements
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Front End Templates (site) |
| Labels |
Added:
?
|
||
@infograf768 can I have a test here please?
I don't think so, those two are related to the session in the php part and if I remember correctly the last page (where someone could select the extra languages and the sample data) somehow have a new session (?). Pretty sure this was fixed at some point by @wilsonge
For this PR a simple check that the media folder is regenerated correctly is all we need...
The media folder is regenerated correctly.
Custom extensions stuff present in media folder on an existing site are not deleted when re-running npm ci
Still the same issue with com_media node_modules which has to be deleted before running npm ci in order to get the files in media/com_media/css and js
see #22860
You're still copying the es6 files at the moment; Given the PR description I guess that's not expected. But everything appears to work fine so merging
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-09 11:31:12 |
| Closed_By | ⇒ | wilsonge |
Given the PR description I guess that's not expected.
The idea is that there is no ES6 but yearly versions of javascript since 2015. Copying the files as is might work right now (If the project decides to deliver actual es-20XX code) but in reality features might need to be polyfilled, depending the target minimum version (the reason is that not all browsers support simultaneously all js features). Anyways since this is not the case right now and since there is way to transpile using poly fills (that was the main point of this PR) copying the files over is not a big deal (is just dead code that inflates the zip files). As I mentioned there gonna be some more PRs on the build tools, so this should be good enough for now
@rdeutz can you restart the tests here?