[#23155] - [4.0] Move mod menu script to es6
- Fixed in Code Base
- 15 Jan 2019
- Medium
- Build: 4.0-dev
- # 23155
- Diff
- dgrammatiko:4.0-dev-es6-mod_menu
User tests: Successful: Unsuccessful:
Pull Request for Issue NAN .
Summary of Changes
Use current javascript
Testing Instructions
Menu still works fine
Expected result
Actual result
Documentation Changes Required
No
PS. The admin menu is still NOT ACCESSIBLE and the current state should not be considered nowhere near production ready... Eg: this needs to be done properly, but in another PR
PS. 2 The other files touched here due to eslint... BTW before compiling eslint should ALWAYS run and prevent compiling if any file fails linting
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
it would really help if you opened an issue
That's not my way, I do PRs not issues
Well how does anyone know what the problem is?
Well a simple comparison with the ARIA best practices example : https://w3c.github.io/aria-practices/examples/menubar/menubar-1/menubar-1.html will reveal all the shortcomings. Still I will not create an issue, I plan to do a PR...
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-01-15 20:00:03 |
| Closed_By | ⇒ | wilsonge |
Instead of saying it's not accessible it would really help if you opened an issue with information exactly what the issues are.