[#23123] - [4.0][com_content] Remove column-related code.
- Fixed in Code Base
- 21 Mar 2019
- Medium
- Build: 4.0-dev
- # 23123
- Diff
- SharkyKZ:removeColumns
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_content SQL Installation Postgresql Plugins |
Can you ask this question in a separate issue? It's quite offtopic here as this PR is completely unrelated to that question.
I asked it here as the file has been modified and the methods may have to be totally deleted if the decision is confirmed. Just a Note to admins.
Still needs an own issue to be properly discussed so it doesn't derail this valid PR here.
sure
| Labels |
Added:
?
?
|
||
Personally I would not remove the language strings from the global language file. When I removed all unused strings earlier I left the ones in global files as those are the files recommended for extensions to utilise and I felt it was an unnecessary additional change they would have to make. My 2c
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23123.
| Category | Administration Language & Strings Front End com_content SQL Installation Postgresql Plugins | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql com_associations com_banners |
| Labels |
Added:
?
Removed: ? |
||
| Category | Administration SQL Postgresql Unit Tests Repository com_admin com_associations com_banners | ⇒ | Administration Language & Strings Front End com_content SQL Installation Postgresql Plugins |
@zero-24 @SniperSister RIPS please
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-21 16:11:30 |
| Closed_By | ⇒ | wilsonge |
Thanks!
NOTE
To @wilsonge @laoneo @Bakual @mbabker @rdeutz
Concerning
installation/src/Model/LanguagesModel.php, what do we do with the methods which have allowed to install a basic multilingual site at installation time in 3.x as it looks like it has been apparently officially decided to drop this functionality in 4.0 in favor of the multilang sample data plugin.I still question this decision btw. And it looks like I am not alone on this.