Feeling Lucky
?
[#23122] - [imp] reset checked_out to DEFAULT instead of 0 in global checkin
- Fixed in Code Base
- 7 Dec 2018
- Medium
- Build: staging
- # 23122
- Diff
- julienV:checkin-use-default
User tests: Successful: Unsuccessful:
Pull Request for Issue #23121 .
Summary of Changes
reset check_out value to DEFAULT instead of 0 in global checkin
Testing Instructions
use global checkin
Expected result
should work
Actual result
doesn't work if the checked_out olumn has a fk constraint on #_users table
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_checkin |
julienV
- comment
- 28 Nov 2018
I guess so, but at least you have the possiblity to override the JTable method in your own child class when developing an extension, which is not the case here. And here it's simple and no side effects.
So it can be done, but maybe in a different merge request... let me know.
csthomas
- comment
- 5 Dec 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23122.
Quy
- comment
- 5 Dec 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23122.
Quy
- comment
- 5 Dec 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23122.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 5 Dec 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23122.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-07 16:25:50 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Looks good for MySql, PostgreSQL and MsSQL
also i don't see how this change can cause any issues
But it should be changed in more places,
The Models will eventually call JTable::checkin()
method in JTable should be updated too ?
https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Table/Table.php#L1098-L1136