[#23073] - [4.0] New banner fails to save
- Closed
- 14 Nov 2018
- Medium
- Build: staging
- # 23073
- Diff
- joomla:4.0-dev
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Failure continuous-integration/drone/push the build failed Details
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23072
Summary of Changes
The problem is on file /administrator/components/com_banners/Table/BannerTable
line 204. Change from:
$client = Table::getInstance('Client', NAMESPACE . '', array('dbo' => $db));
to
$client = new ClientTable($db);
Testing Instructions
Create new banner
Put a title
Choose a client.
Save.
Expected result
To save a new banner on the selected client.
Actual result
An error has occurred.
0 Call to a member function load() on boolean
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin |
Obviously you made this PR against the wrong branch: It should be 4.0-dev, but you made it for staging (which is 3.9)
Ooops. Can I change it, or need to create new?
You can change it. Click Edit button to the right of the title.
Ooops. Can I change it, or need to create new?
When you click edit button it will allow you edit the title of this PR but also you can change the branch
https://help.github.com/articles/changing-the-base-branch-of-a-pull-request/
Thanks. I just did.
Change it to 4.0-dev, not l10n_4.0-dev.
There is no option for 4.0-dev
I guess you somehow screwed up this pr. Probably the best option would be to create a new one.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-14 11:44:46 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Repository Administration com_admin | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
You're trying to merge 4.0 from the CMS into another repo. I assume you meant to do a PR from your own fork
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-11-14 11:44:46 | ⇒ | |
| Closed_By | wilsonge | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-14 11:48:28 |
| Closed_By | ⇒ | wilsonge |
Obviously you made this PR against the wrong branch: It should be 4.0-dev, but you made it for staging (which is 3.9)