[#23055] - [4.0] Remove obsolete menu class "nav-pills" from menu modules' parameters and contact links
- Fixed in Code Base
- 14 Dec 2018
- Medium
- Build: 4.0-dev
- # 23055
- Diff
- richard67:remove-menu-class-nav-pills
User tests: Successful: Unsuccessful:
Pull Request for Issue #23023 .
Summary of Changes
Remove the obsolete menu class "nav-pills" from contact default links markup and blog sampledata plugin menu creation.
Testing Instructions
Code review for the sample data part, patch tester and check that contact links look like without this PR for the contact links part.
Expected result
The menu class "nav-pills" is not added in blog sample data for menus at module position "top-a", e.g. the "Main Menu Blog", and also not added to the markup of the contact links list (<ul> element).
Actual result
The menu class "nav-pills" is added in blog sample data for menus at module position "top-a", e.g. the "Main Menu Blog", but it has no effect.
This might confuse administrators who create or maintain menu modules.
The CSS class nav-pills" is also added to the markup of the contact links list (<ul> element), but it has no effect there because the links list doesn't have an active element on which the pills effect should be applied.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact Plugins |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.
| Labels |
Added:
?
|
||
@ciar4n Could you set your test result again? It has been reset by branch update to latest 4.0-dev. There have not been made any changes. Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.
Thanks a lot. Hope we find a 2nd tester.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.
@infograf768 Thanks a lot.
@richard67
Maybe you have time to test:
#23143 (RTL stuff too)
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-12-14 15:37:22 |
| Closed_By | ⇒ | wilsonge |
Thanks guys! Sorry for the delay on merging
@ciar4n Could you review or test this PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23055.