[#23054] - [4.0] Remove obsolete module class "_menu" from menu modules' parameters
- Fixed in Code Base
- 14 Nov 2018
- Medium
- Build: 4.0-dev
- # 23054
- Diff
- richard67:remove-module-class-menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #23023 .
Summary of Changes
Remove unused module class (formerly called module class suffix) "_menu" from menu modules' parameters in new installation and sample data.
Testing Instructions
Code review.
Expected result
The module class "_menu" is not added to parameters of any menu modules on new installation and on any kind of sample data installation.
Actual result
The module class "_menu" is added to the parameters of the default "Main Menu" on new installation of J4, of diverse menus in testing sample data and of the language-specific main menus in multilanguage sample data, but it has no effect on styling.
In comparison to that, when creating a new menu, the module class "_menu" is not added to the new menu.
This inconistency and the obsolete module class added in the cases mentioned above might confuse administrators who create or maintain menu modules.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23054.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23054.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23054.
Thanks to all testers.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-14 19:24:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks, too.
@ciar4n Could you review or test this PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23054.