Incorrect return types documented.
Labels |
Added:
?
|
@SharkyKZ parent::save might return something to this function, but this fuction DOESNT return that value, it returns void, when the documentation states it returns a boolean.
maybe this function should add return like
return parent::save($key, $urlVar);
or the documentation should be updated to state the return type is void.
Yes, you're right. There are several instances of this.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-12 18:19:08 |
Closed_By | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23021
For first point test PR #23026.
Second point is correct, I think. It calls parent's
save()
method which should return a boolean. See https://github.com/joomla/joomla-cms/blob/b7673120c5b26544756c5bb50e1695c5dfaa820f/libraries/src/MVC/Controller/FormController.php