?
avatar PhilETaylor
PhilETaylor
9 Nov 2018

On code review saw

screenshot 2018-11-09 at 22 19 49

Probably needs fixing, and im about to go to bed, but im guessing this might fatal error on this. (Im correct on this from a quick google search)

avatar PhilETaylor PhilETaylor - open - 9 Nov 2018
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Nov 2018
avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

This is one for @mbabker as the actual file is /libraries/joomla/session/src/StorageInterface.php in 4.0 - but I cannot find the other source repo for that file.

avatar PhilETaylor PhilETaylor - change - 9 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 9 Nov 2018
avatar PhilETaylor PhilETaylor - change - 9 Nov 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-11-09 22:40:01
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 9 Nov 2018
avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

scrap that - I think this is a phpStorm issue

avatar SharkyKZ
SharkyKZ - comment - 9 Nov 2018

This should be fine on PHP 7.1.

avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

yes but Joomla 4 is from 7.0 onwards right?

avatar mbabker
mbabker - comment - 9 Nov 2018

Check your IDE settings. Scalar typehints are OK in PHP 7, PHP 5 gives
that type of warning if you’re inspecting for it.

BTW all the Joomla vendor files are in the Joomla-Framework repos.

On Fri, Nov 9, 2018 at 4:40 PM SharkyKZ notifications@github.com wrote:

This should be fine on PHP 7.1.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#23020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVW2XNV5Zy95xh9__RleBs9XpDO7ks5utgRvgaJpZM4YXmvG
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar PhilETaylor
PhilETaylor - comment - 9 Nov 2018

PHPStorm is using PHP level 7.0 as it reads it from the composer.json file and syncs its settings

I think the PHPStorm Inspector might have other ideas and might be using an older PHP version for some reason.

https://3v4l.org/UUOnS confirms that it would fail in 5.6 but not 7.0.32

Case closed zzzz...

Add a Comment

Login with GitHub to post a comment