Labels |
Added:
?
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-09 22:40:01 |
Closed_By | ⇒ | PhilETaylor |
scrap that - I think this is a phpStorm issue
This should be fine on PHP 7.1.
yes but Joomla 4 is from 7.0 onwards right?
Check your IDE settings. Scalar typehints are OK in PHP 7, PHP 5 gives
that type of warning if you’re inspecting for it.
BTW all the Joomla vendor files are in the Joomla-Framework repos.
On Fri, Nov 9, 2018 at 4:40 PM SharkyKZ notifications@github.com wrote:
This should be fine on PHP 7.1.
—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
#23020 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfoVW2XNV5Zy95xh9__RleBs9XpDO7ks5utgRvgaJpZM4YXmvG
.
--
PHPStorm is using PHP level 7.0 as it reads it from the composer.json file and syncs its settings
I think the PHPStorm Inspector might have other ideas and might be using an older PHP version for some reason.
https://3v4l.org/UUOnS confirms that it would fail in 5.6 but not 7.0.32
Case closed zzzz...
This is one for @mbabker as the actual file is /libraries/joomla/session/src/StorageInterface.php in 4.0 - but I cannot find the other source repo for that file.