[#22998] - s/overriden/overridden
- Fixed in Code Base
- 12 Nov 2018
- Medium
- Build: 4.0-dev
- # 22998
- Diff
- PhilETaylor:overriden
User tests: Successful: Unsuccessful:
s/overriden/overridden
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media com_newsfeeds com_redirect com_tags Language & Strings JavaScript Repository Front End com_contact com_content Libraries |
I have tested this item
blind search and replace is dangerous. please dont change third party files. Any issues with them should be reported upstream
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
I have not tested this item.
Reverting test for reasons stated above by Brian in his negative test result and .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
This was NOT a blind search and replace
None of last nights PRs were
I made a mistake with a single line in a single file right before bed. Get over it!
——
Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later.
——
On 10 Nov 2018, at 13:14, Brian Teeman notifications@github.com wrote:
I have tested this item
? unsuccessfully on d8831f0blind search and replace is dangerous. please dont change third party files. Any issues with them should be reported upstream
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
| Labels |
Added:
?
?
|
||
One file reported upstream here jquery/jquery-ui#1876
After some struggles with Github Online Editor ALWAYS adding a blank line at the end of the file, the vendor file is now reverted, and reported upstream, this is now ready for "testing" again.
I have tested this item
Code review + check that this PR covers all occurrences of wrong English "overriden" (case-insensitive) in Joomla 4 except of the 3rd party library file.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.
laoneo
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-12 08:42:16 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on d8831f0
Code review + check that this PR covers all occurrences of wrong English "overriden" (case-insensitive) in Joomla 4.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22998.