? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
9 Nov 2018

Summary of Changes

Move the Joomla Admin Left Menu -> Toggle Menu to the bottom of the menu instead of being at the top, where the most important item "Control Panel" should be.

Testing Instructions

Get a stable Joomla 4 build
apply PR

Expected result

Toggle Menu now at the bottom of the menu

screenshot 2018-11-09 at 20 16 51

Actual result

Before PR - Toggle Menu at the top of the left menu

screenshot 2018-11-09 at 20 16 23

avatar PhilETaylor PhilETaylor - open - 9 Nov 2018
avatar PhilETaylor PhilETaylor - change - 9 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2018
Category Modules Administration
avatar PhilETaylor PhilETaylor - change - 9 Nov 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 9 Nov 2018
avatar PhilETaylor PhilETaylor - change - 9 Nov 2018
Labels Added: ?
avatar infograf768
infograf768 - comment - 10 Nov 2018

Not sure about that one because we will hopefully finally correct creating custom admin menus and the list may be much longer and force scrolling down.

I would rather see this toggle button get a different kind of display than the menus themselves.
Something like:

screen shot 2018-11-10 at 10 18 10

avatar PhilETaylor
PhilETaylor - comment - 10 Nov 2018

Well if this option is going to stay as a menu item, then maybe its best refactored out as a MenuType (like the separator is) so that it can be added anywhere, instead of being hard coded in one place.

I dont like that - but its better than it being in PRIME POSITION in the menu structure and in the way for those that never collapse the left menu.

This option is NOT a menu item in the true sense of the word "menu item" - its a toggle, a switch, a system function.

Personally, I think the best place for it might actually be hard coded where the Joomla logo is in the foot of the left bar.

avatar C-Lodder
C-Lodder - comment - 11 Nov 2018

Placing it at the bottom only works if:

  • The sidebar has a max height of 100%
  • The toggle is fixed to the bottom of the sidebar
  • The sidebar menu itself is scrollable (toggle doesnt move)

Else you'll find users on smaller devices having to scroll to access the toggle.

I agree about it being refactored out as a MenuType

avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:36:15
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment