? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
1 Nov 2018

Pull Request for Issue #22896

Summary of Changes

  • Correct default value of parameter url in xml
  • Add filter integer to 0/1 parameter link_to_alias in xml
  • Respect/Force default values in php if plugin settings are not newly saved by user
  • Force integer for link_to_alias (B\C) in php
  • type-safe comparisons

Testing Instructions

  • Install Joomla 3.9.0 or update from 3.8.x to 3.9.0
  • Don't save the plugin settings of plg_content_contact !
  • Create Contact and assign Linked User
  • Create Article created by user linked to contact
  • Set content component Show Author and Link Author to Yes, and set menu/article settings to use global

Expected result

  • Code falls back to default values if user doesn't save the plugin settings
  • Article displays link to contact page of author.

Actual result

avatar ReLater ReLater - open - 1 Nov 2018
avatar ReLater ReLater - change - 1 Nov 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2018
Category Front End Plugins
avatar ReLater ReLater - change - 1 Nov 2018
Labels Added: ?
avatar ReLater ReLater - change - 1 Nov 2018
The description was changed
avatar ReLater ReLater - edited - 1 Nov 2018
avatar ReLater ReLater - change - 1 Nov 2018
The description was changed
avatar ReLater ReLater - edited - 1 Nov 2018
avatar danmorell
danmorell - comment - 1 Nov 2018

I have tested this item successfully on 3bdb2b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22904.

avatar danmorell danmorell - test_item - 1 Nov 2018 - Tested successfully
avatar Quy
Quy - comment - 1 Nov 2018

I have tested this item successfully on 3bdb2b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22904.

avatar Quy Quy - test_item - 1 Nov 2018 - Tested successfully
avatar Quy Quy - change - 1 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22904.

avatar mbabker mbabker - change - 5 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-05 23:17:10
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Nov 2018
avatar mbabker mbabker - merge - 5 Nov 2018

Add a Comment

Login with GitHub to post a comment