[#22852] - [4.0] Fix broken preset menu import
- Fixed in Code Base
- 2 Nov 2018
- Medium
- Build: 4.0-dev
- # 22852
- Diff
- bembelimen:create-preset-menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #18684 #19904 #22758 .
Summary of Changes
This problem is a bit complicated because there are two bugs, which are overlaying.
First: When a non component menu entry will be imported by the preset, the component_id is missing (fixed here: https://github.com/joomla/joomla-cms/pull/22852/files#diff-1b5557519e9638a5bde91cf3432456dfR490)
Second: if the menu saving failed for new menu items, the model still tries to publish non existing items (without an id) and throws another error (fixed here; https://github.com/joomla/joomla-cms/pull/22852/files#diff-8987d50fd63f0f6c70155058af33e7abR904).
Testing Instructions
Create a backen menu and choose a preset.
Expected result
Preset is imported
Actual result
Preset import fails
See #22853 for the follow up bug (not related to this fixes)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries |
| Labels |
Added:
?
|
||
I have tested this item
Thank you, @bembelimen, just what I needed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.
@bembelimen do you change this pr, or do you create a new one for J3?
For j3 is a new PR needed. This is fine as it is.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-02 08:18:48 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Ok, thanks
Preset is created after this patch. Only the direct links do work. Items which use collapse don't.