? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
29 Oct 2018

Pull Request for Issue #18684 #19904 #22758 .

Summary of Changes

This problem is a bit complicated because there are two bugs, which are overlaying.
First: When a non component menu entry will be imported by the preset, the component_id is missing (fixed here: https://github.com/joomla/joomla-cms/pull/22852/files#diff-1b5557519e9638a5bde91cf3432456dfR490)
Second: if the menu saving failed for new menu items, the model still tries to publish non existing items (without an id) and throws another error (fixed here; https://github.com/joomla/joomla-cms/pull/22852/files#diff-8987d50fd63f0f6c70155058af33e7abR904).

Testing Instructions

Create a backen menu and choose a preset.

Expected result

Preset is imported

Actual result

Preset import fails

See #22853 for the follow up bug (not related to this fixes)

avatar bembelimen bembelimen - open - 29 Oct 2018
avatar bembelimen bembelimen - change - 29 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2018
Category Administration com_menus Libraries
avatar bembelimen bembelimen - change - 29 Oct 2018
The description was changed
avatar bembelimen bembelimen - edited - 29 Oct 2018
avatar bembelimen bembelimen - change - 29 Oct 2018
The description was changed
avatar bembelimen bembelimen - edited - 29 Oct 2018
avatar bembelimen bembelimen - change - 29 Oct 2018
The description was changed
avatar bembelimen bembelimen - edited - 29 Oct 2018
avatar infograf768
infograf768 - comment - 30 Oct 2018

Preset is created after this patch. Only the direct links do work. Items which use collapse don't.

avatar bembelimen bembelimen - change - 31 Oct 2018
Labels Added: ?
avatar chmst
chmst - comment - 1 Nov 2018

I have tested this item successfully on b0a57f2

Thank you, @bembelimen, just what I needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.

avatar chmst chmst - test_item - 1 Nov 2018 - Tested successfully
avatar Quy
Quy - comment - 1 Nov 2018

This PR is for v4 yet #19904 pertains to v3. Will a separate PR be created for it?

avatar bembelimen
bembelimen - comment - 1 Nov 2018

@Quy I did not tackle this problem (yet) in this PR. Could you please check if this problem is also in J! 4? Then I'll update this PR and we can convert it to J! 3.

avatar Quy
Quy - comment - 1 Nov 2018

I have tested this item successfully on f00d6ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.

avatar Quy Quy - test_item - 1 Nov 2018 - Tested successfully
avatar Quy Quy - change - 1 Nov 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Nov 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22852.

avatar laoneo
laoneo - comment - 2 Nov 2018

@bembelimen do you change this pr, or do you create a new one for J3?

avatar bembelimen
bembelimen - comment - 2 Nov 2018

For j3 is a new PR needed. This is fine as it is.

avatar laoneo laoneo - change - 2 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-02 08:18:48
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 2 Nov 2018
avatar laoneo laoneo - merge - 2 Nov 2018
avatar laoneo
laoneo - comment - 2 Nov 2018

Ok, thanks

Add a Comment

Login with GitHub to post a comment