PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar dneukirchen
dneukirchen
29 Oct 2018

Summary of Changes

When you currently change the state of items (published, unpublished, trashed...)in the list via inline or toolbar button, joomla does not care about the current state of the item.

This affects the notification (x items published...) and more importantly it also affects the primary keys that are passed to the onContentChangeState event (it passes all primary keys of all selected items including the ones where the state did not change). A plugin that listens to this event has no possibility to check if i.e. an article was unpublished before, because the value in db already changed.

After these changes we pass only the pks that really should be/changed to the table and plugin event. If there are no items to change, we respond with a success message "0 items published".

Because we already load the item, no additional query is needed.

Testing Instructions

Go to article Manager, set one article as unpublished.
Checkall articles and publish them.

bildschirmfoto 2018-10-29 um 14 12 54

As the change was made in ArticleModel this will affect all Models in the backend, that are extending it. So it would be good to test other entities as well.

Before Changes:

bildschirmfoto 2018-10-29 um 14 13 13

After Changes:

bildschirmfoto 2018-10-29 um 14 13 35

When no items were published:

bildschirmfoto 2018-10-29 um 14 14 47

avatar dneukirchen dneukirchen - open - 29 Oct 2018
avatar dneukirchen dneukirchen - change - 29 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2018
Category Libraries
avatar dneukirchen dneukirchen - change - 29 Oct 2018
Labels Added: PR-staging
avatar dneukirchen dneukirchen - change - 29 Oct 2018
The description was changed
avatar dneukirchen dneukirchen - edited - 29 Oct 2018
avatar bembelimen
bembelimen - comment - 29 Oct 2018

I have tested this item successfully on 3544a47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22851.

avatar bembelimen bembelimen - test_item - 29 Oct 2018 - Tested successfully
avatar Quy
Quy - comment - 29 Oct 2018

I have tested this item successfully on 3544a47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22851.

avatar Quy Quy - test_item - 29 Oct 2018 - Tested successfully
avatar Quy Quy - change - 29 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22851.

avatar mbabker mbabker - change - 5 Nov 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-11-05 23:17:57
Closed_By mbabker
Labels Added: RTC
avatar mbabker mbabker - close - 5 Nov 2018
avatar mbabker mbabker - merge - 5 Nov 2018
avatar Quy
Quy - comment - 6 Nov 2018

@dneukirchen Under Extensions > Plugins, it is not possible to toggle under the Status column.

avatar dneukirchen
dneukirchen - comment - 6 Nov 2018

Will take a look tomorrow.

Add a Comment

Login with GitHub to post a comment