[#22817] - [4.0] Fix Image API use
- Discussion
- Medium
- Build: master
- # 22817
In 3.x we made the Joomla\CMS\Image classes extend the Joomla\Image classes from the Framework and deprecated the CMS classes. After this happened, we decided to deprecate the Framework package. So, the CMS needs to break this class inheritance (which is technically a B/C break) and basically inline all the code back into the CMS namespace.
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Labels |
Added:
J4 Issue
|
||
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | Code style |
| Labels |
Added:
?
|
||
| Category | Code style | ⇒ |
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-24 12:05:34 |
| Closed_By | ⇒ | mbabker |
This needs to be done one way or another. I could give it a try but I have no idea how to map Framework versions to CMS versions.
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-05-24 12:05:34 | ⇒ | |
| Closed_By | mbabker | ⇒ |
Framework 1.x is used in CMS 3.x
Framework 2.x is used in CMS 4.x
For all intents and purposes, you just need to copy the code from the Joomla\Image classes back into Joomla\CMS\Image classes and undo the deprecations of the CMS' classes and not have them extend the Framework classes. Then joomla/image can be removed from the Composer manifest.
What about doc blocks? For example, Joomla\Image\Image::$generateBestQuality has @since 1.4.0 while Joomla\CMS\Image\Image::$generateBestQuality has @since 3.7.0. I suppose we should use CMS versions. But what about versions for methods and properties not documented in CMS, e.g. Joomla\Image\Image::watermark() with 1.3.0 version?
The version it was introduced into the CMS API is what the doc block should be.
| Status | New | ⇒ | Discussion |
Hmm, not the template or the test architecture. Odds are nobody's touching it.