Feeling Lucky
?
[#22633] - Add forgotten css class to com_fields display front-end
- Closed
- 17 Oct 2018
- Medium
- Build: staging
- # 22633
- Diff
- ghazal:patch-1
User tests: Successful: Unsuccessful:
When exploring settings of a field, we should be able to add a css class to Render Class in Render Options, tab Options.
Actual result:
<span class="field-label labelcssadded">Title of the field</span>
<span class="field-value">
Expected result:
<span class="field-label labelcssadded">Title of the field</span>
<span class="field-value valuecssadded">
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields |
| Labels |
Added:
?
|
||
ghazal
- comment
- 17 Oct 2018
OK, there was a mix-up from my part.
I assumed that the staging branch refers to 3.9 (rc2) because there is no 3.9 version in the branch list.
I guess I shouldn't have.
3. 8 and 3.9 back-end display for a field Options are different.
3.8
3.9
Anyway, I'll close this post, revise the code, and post for 3.9.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-17 11:40:43 |
| Closed_By | ⇒ | ghazal |
This class is used here https://github.com/joomla/joomla-cms/blob/staging/components/com_fields/layouts/fields/render.php#L59. In your pr, the class is added then two times.
If you want a new class for the value, then you need to introduce a new parameter. But honestly I doubt that it is really needed.