J3 Issue ?
avatar PhilETaylor
PhilETaylor
15 Oct 2018

Steps to reproduce the issue

have a MASSIVE session table

Joomla will run non optimised, non indexed queries like

SELECT COUNT(session_id)
  FROM ltm4b_session
  WHERE guest = 0 
  AND client_id = 0

Expected result

Optimised performance

Actual result

Bad performance

Additional comments

Recommend the following index:

ALTER TABLE `#__session` ADD INDEX (`client_id`, `guest`);
avatar PhilETaylor PhilETaylor - open - 15 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Oct 2018
avatar PhilETaylor PhilETaylor - change - 15 Oct 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 15 Oct 2018
avatar PhilETaylor PhilETaylor - change - 15 Oct 2018
The description was changed
avatar PhilETaylor PhilETaylor - edited - 15 Oct 2018
avatar alikon
alikon - comment - 15 Oct 2018

can you quantify Massive ?

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

can you quantify Massive ?

No.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

On dev mac

13000 rows = query time for above query without index = 9.31 ms
13000 rows = query time for above query with index = 0.55 ms

avatar SharkyKZ
SharkyKZ - comment - 15 Oct 2018

Related/duplicate #21555. Use userid instead of guest.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

Not a duplicate. Just something else to address.

avatar brianteeman
brianteeman - comment - 15 Oct 2018

Instead of posting the code that you want to be changed in an issue report - please submit a pull request. You shouldn't expect people to do your work for you. It's not s if you don't know how to write the code!!!

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

Brian

It's because of people like you - no, you specifically, that I do not contribute to this project as much as I used to. You really are stuck up yourself eh?

Its not code "I want changed"

Its not "my work" Im expecting people to do.

It's called contributing ... if you do not count issues as contributing then thats not my problem. if you do not count issues as contributing then that counts out 90% of your "contribution" to this project

This is the reason you have spent the last 3 years blocked. And the reason I will again block you right now.

I'm disappointed that once again you chose personal attacks of those actually contributing. And yes, raising issues REGARDLESS OF ABILITY is contributing. Not everyone has no job and can just drop everything to code. It's not always appropriate to be fixing issues at the same time as reporting them. Different hats for different times.

Ironically, someone literally just told me you would start with these personal attacks, and within an hour you started again.

Pathetic.

Edit:
Also unlike you, Im not arrogant to believe I have all the answers to the problems, and I don't believe my solutions are always the best solution, so raising an issue for discussion, rather than wasting time on a PR that will not be accepted, is the CORRECT action.

avatar brianteeman
brianteeman - comment - 15 Oct 2018

Glad I am blocked so I dont have to read your egotistical rants. Unlike you I don't pretend to my clients that I am a core contributor to Joomla. I contribute because that is what community is all about. What you do is leach, moan and use Joomla only when it suits you for commercial gain.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2018

Personal attacks will not be tolerated.

avatar brianteeman
brianteeman - comment - 15 Oct 2018

truth hurts

avatar laoneo
laoneo - comment - 15 Oct 2018

I locked this issue as the focus get lost. If somebody feels like to open a pr with the index change, this is very welcome.

avatar brianteeman brianteeman - change - 16 Oct 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 16 Oct 2018
avatar Bakual
Bakual - comment - 16 Oct 2018

Closing since there is a PR: #22668

avatar Bakual Bakual - close - 16 Oct 2018
avatar Bakual Bakual - change - 16 Oct 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-10-16 15:22:35
Closed_By Bakual

Add a Comment

Login with GitHub to post a comment