? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Oct 2018

Pull Request for Issue #22532

Summary of Changes

When saving a module in frontend, the link created wrongly uses com_config in the url.
This PR checks the $table to get com_modules which is the right $option in this case.

Testing Instructions

See #22532

@alikon

avatar infograf768 infograf768 - open - 8 Oct 2018
avatar infograf768 infograf768 - change - 8 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2018
Category Front End Plugins
avatar Quy
Quy - comment - 8 Oct 2018

I have tested this item successfully on 24b5db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

avatar Quy Quy - test_item - 8 Oct 2018 - Tested successfully
avatar alikon
alikon - comment - 8 Oct 2018

I have tested this item successfully on 24b5db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

avatar alikon alikon - test_item - 8 Oct 2018 - Tested successfully
avatar Quy Quy - change - 8 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 8 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

avatar infograf768 infograf768 - change - 9 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-09 07:23:02
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 9 Oct 2018
avatar infograf768 infograf768 - merge - 9 Oct 2018
avatar joomdonation
joomdonation - comment - 9 Oct 2018

This looks like a dirty fix for me. When a module is saved from frontend, the context is com_modules.module. I wonder if we should get $option directly from first part of context instead of getting it from input? The same could be applied for $option from other methods in the plugin. Thought?

avatar infograf768
infograf768 - comment - 10 Oct 2018

If we do that, it should indeed be done globally.
A bit late for 3.9.0 (RC today). Maybe for 3.9.1 ?

Add a Comment

Login with GitHub to post a comment