Do you have a link/code snippet how this should look like?

For users using screenreaders this could be addressed by adding the text inside a sr-only span

<joomla-toolbar-button id="toolbar-help">
<button class="button-help btn btn-info" type="button" onclick="Joomla.popupWindow('https://help.joomla.org/proxy?keyref=Help40:Content_Article_Manager&amp;lang=en', 'Help', 700, 500, 1)">
	<span class="fa fa-question" aria-hidden="true"></span>
	Help
	<span class="sr-only">Opens in a new window</span>
</button>
</joomla-toolbar-button>

For sighted users we can simply use the title attribute so the full markup would be

<joomla-toolbar-button id="toolbar-help">
<button class="button-help btn btn-info" type="button" onclick="Joomla.popupWindow('https://help.joomla.org/proxy?keyref=Help40:Content_Article_Manager&amp;lang=en', 'Help', 700, 500, 1)"
title="Opens in a new window">
	<span class="fa fa-question" aria-hidden="true"></span>
	Help
	<span class="sr-only">Opens in a new window</span>
</button>
</joomla-toolbar-button>

Instead of using the title we could use the fa-external-link icon like on the admin login screen but in this case I think it would not be clear

@brianteeman in which file should the above code has to go ?

If I knew that I would have done it myself :)

The output is here: https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/toolbar/basic.php

Is there any thing remains to be changed @bembelimen as I think the above file already has the code as suggested by @brianteeman

@hardik-codes no it doesn't. if it did then there wouldnt be an issue to fix :)

Working on it

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/22544

closed as having Pull Request #24138

Set to "open" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/22544

Closed as having Pull Request #25519