? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Oct 2018

this Pr is for the the buttons on the joomla stats popup buttons

image

Before this pr they were <a href= with a class to make them look like buttons but without a role=nutton

They are visually styled as buttons and they work like buttons so they should behave as buttons and be identified as buttons

The default behaviour for a button is for it to be selected by either space or enter whereas the default behaviour for a link is for it only to be selected by the enter key.

There is no visual change - however if you use the tab key to navigate to the buttons you will be able to test that you can select the button and a modal opens by pressing the space bar as well as the enter key.

Please dont tell me about other areas of core that are also wrong - there are a lot - and I will submit discrete pr for them - as it will be easier to test

avatar brianteeman brianteeman - change - 5 Oct 2018
Status New Pending
avatar brianteeman brianteeman - open - 5 Oct 2018
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2018
Category Front End Plugins
avatar Quy
Quy - comment - 5 Oct 2018

I have tested this item successfully on 50b3bb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22508.

avatar Quy Quy - test_item - 5 Oct 2018 - Tested successfully
avatar wilsonge wilsonge - change - 6 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-06 18:16:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 6 Oct 2018
avatar wilsonge wilsonge - merge - 6 Oct 2018
avatar wilsonge
wilsonge - comment - 6 Oct 2018

Thanks!

avatar brianteeman
brianteeman - comment - 6 Oct 2018

thanks

Add a Comment

Login with GitHub to post a comment