User tests: Successful: Unsuccessful:
this Pr is for the the buttons on the joomla stats popup buttons
Before this pr they were <a href=
with a class to make them look like buttons but without a role=nutton
They are visually styled as buttons and they work like buttons so they should behave as buttons and be identified as buttons
The default behaviour for a button is for it to be selected by either space or enter whereas the default behaviour for a link is for it only to be selected by the enter key.
There is no visual change - however if you use the tab key to navigate to the buttons you will be able to test that you can select the button and a modal opens by pressing the space bar as well as the enter key.
Please dont tell me about other areas of core that are also wrong - there are a lot - and I will submit discrete pr for them - as it will be easier to test
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-06 18:16:26 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
thanks
I have tested this item✅ successfully on 50b3bb9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22508.