[#22507] - [4.0] plugin statistics popup not an alert
- Closed
- 3 Jun 2019
- Medium
- Build: master
- # 22507
This should not have a role=alert as this role does not allow for a response by the user, instead it should have a role=alertdialog
Not sure if it is best to create a new custom element for alertdialog of if it should be an option passed to the existing alert custom element.
In addition it should receive focus https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alertdialog_role
| Labels |
Added:
?
|
||
| Labels |
Added:
J4 Issue
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-11-08 13:17:46 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-11-08 13:17:46 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
@brianteeman where is role=alert defined ?
As I'm not able to find it in message.php
| Title |
|
||||||
| Status | New | ⇒ | Discussion |
| Category | ⇒ | Accessibility |
@brianteeman can you please help?
| Status | Discussion | ⇒ | Information Required |
If i could have fixed it myself i would already have done so
| Labels |
Added:
?
|
||
| Category | Accessibility | ⇒ |
| Title |
|
||||||
| Title |
|
||||||
I assume this is upstream:
\media\vendor\joomla-custom-elements\js\joomla-alert.js
role is set here:
/* Lifecycle, element appended to the DOM */
connectedCallback() {
this.setAttribute('role', 'alert');
this.classList.add('joomla-alert--show');
Upstream is joomla-projects/custom-elements#118
Please test joomla-projects/custom-elements#119
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-03 06:46:06 |
| Closed_By | ⇒ | joomla-cms-bot |
| Status | Closed | ⇒ | Information Required |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 2019-06-03 06:46:06 | ⇒ | 2019-06-03 06:46:07 |
| Closed_By | joomla-cms-bot | ⇒ | alikon |
| Labels | |||
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/22507
closed as we have a pr joomla-projects/custom-elements#119
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22507.
@brianteeman Working on it