User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Install Joomla, spinner is ok
Make sure that you have custom fields assigned to one category. Edit an article and change its cat to the one that custom fields are attached. spinner is ok
Try a multilingual and check if the spinner works ok
In 4.0 in each page that a spinner is needed the following steps will need to be done:
HTMLHelper::_('webcomponent', 'system/webcomponents/joomla-core-loader.min.js', ['relative' => true, 'version' => 'auto']);
spinner = document.createElement('joomla-core-loader');
// Assuming that the spinner is full screen
document.body.appendChild(spinner);
/*
if we need to append the spinner to some other container
all we have to do is replace document.body with the element
that we want the spinner to appear
*/
spinner = document.querySelector('joomla-core-loader');
spinner.parentNode.removeChild(spinner);
if you want to use the same codebase for different versions (j3 and j4) here is a quick code:
if (Joomla.loadingLayer && typeof Joomla.loadingLayer === 'function') {
// We are in J3 so use the old method
Joomla.loadingLayer('show');
} else {
// We are in the future
spinner = document.createElement('joomla-core-loader');
document.body.appendChild(spinner);
}
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_associations com_categories com_fields Modules JavaScript Repository Installation Layout |
Labels |
Added:
?
|
It’s a take it or leave it...
Thats a shame as its not the right thing to do (as you well know) and its the reason why whe in the past pr's with multiple issues were merged we are wasting time undoing all the mistakes.
@Fedik unfortuanatelly this is a really poor implementation with so many anti patterns so at some point it needs to be done.
I know it’s a pain but at some point these needs to be done correctly...
As I am currently wasting a lot of time redoing a lot of work that was committed in error because it was not tested properly because it was buried in a big pr with other things we must stop accepting any pr that addresses multiple issues at the same time. It is a waste of people's limited time to have to redo things that were not able to be tested!
Category | Administration com_associations com_categories com_fields Modules JavaScript Repository Installation Layout | ⇒ | Administration com_associations com_categories com_fields JavaScript Repository Installation Layout |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-04 09:54:29 |
Closed_By | ⇒ | dgrammatiko |
Ok good luck
There are multiple issues being addressed in this one pr and it really should be one issue per pr. It makes testing much more reliable and avoids parts of the pr not being tested etc