[#22475] - Compact image modal layout
- Fixed in Code Base
- 15 Jun 2019
- Medium
- Build: staging
- # 22475
- Diff
- ciar4n:image-modal
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Compacts the media field modal layout and increases modal size. Removes the double scroll bar on larger screens. Currently, there are 3 options to close. This PR removes the close button in the footer (admin).
Testing Instructions
Apply PR and open administration media modal (media field -> select).
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media Templates (admin) JavaScript |
| Labels |
Added:
?
|
||
| Category | Administration com_media Templates (admin) JavaScript | ⇒ | Administration com_media Templates (admin) |
Toolbar is no longer pinned with this PR.
Not sure if I understand. Would you have a screenshot?
With this PR, go to Content > Articles, scroll down and the toolbar goes off screen and no longer is pinned.
Strangely I am unable to replicate this issue. Toolbar is sticking in both Firefox and Chrome.
Using your branch, it is not an issue. However, with beta4 and patchtester, then it is reproducible.
An issue because of patchtester doesn't mean the patch has issues. It could very well be there is another change after beta 4 that patchtester isn't applying which is causing what you're seeing.
It is literally impossible to make patchtester behave the same as if you're running git apply PR.diff because the CMS environment does not have the git environment data necessary to generate the appropriate diffs.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475.
It's better but I still have a small scroll (unlike your screenshot)
Tested on Chrome 70 Windows
@brianteeman Should be ok now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475.
Tested again with
Firefox 64.0.2 (64-bit) Windows
Version 71.0.3578.98 (Official Build) (64-bit) Windows
I still have the same results as in #22475 (comment)
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
System information
- 3.9, latest nightly build
- Template: Protostar
- macOS High Sierra, 10.13.6
- Firefox 66 (64-bit)
CloudAccess.net
- PHP 7.1.27
- MySQLi 5.7.24-cll-lve
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475.
I have tested this item
Details coming ...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22475.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
I don't think this can be RTC as @brianteeman is still seeing an issue
| Status | Ready to Commit | ⇒ | Pending |
@brianteeman Can you please test again?
Tested fine on Windows 10:
Firefox 67.0.2
Chrome 75.0.3770.80
@HLeithner As release leader, I will let you decide.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-15 09:00:22 |
| Closed_By | ⇒ | HLeithner |
It works for me fine in ff and vivaldi. I have have no idea why brian has this problem but I think its better to merge it then having the current state.
thx
Thanks all for the tests
Hopefully, you can come up with a fix for this related issue #17551.