? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
3 Oct 2018

Summary of Changes

As title says.

Testing Instructions

Load administrator/index.php?option=com_admin&view=help

Before patch

screen shot 2018-10-03 at 10 24 48

After patch

screen shot 2018-10-03 at 10 28 45

avatar infograf768 infograf768 - open - 3 Oct 2018
avatar infograf768 infograf768 - change - 3 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2018
Category Administration
avatar brianteeman
brianteeman - comment - 3 Oct 2018

Isn't this file supposed be generated from the script in the build folder and not edited directly?

avatar infograf768
infograf768 - comment - 3 Oct 2018

Not obvious. It could indeed be via helpTOC.php

Therefore, it would depend on the wiki help version which does not exist for 4.0, this could be the reason why weblinks is still proposed.

@mbabker @wilsonge
If this is the case, I guess I can close this.

avatar wilsonge
wilsonge - comment - 3 Oct 2018

Yes this file should be generated from the script :)

avatar infograf768
infograf768 - comment - 3 Oct 2018

Hmm. I patched and then ran npm install and the file is NOT modified.
Therefore it seems that it does not depend on anything in build, as far as I could see.

avatar infograf768
infograf768 - comment - 3 Oct 2018

so, which script is it?

avatar brianteeman
brianteeman - comment - 3 Oct 2018

helpTOC.php in the build folder

avatar infograf768
infograf768 - comment - 3 Oct 2018
avatar brianteeman
brianteeman - comment - 3 Oct 2018

why would that have anything to do with npm install

avatar brianteeman
brianteeman - comment - 3 Oct 2018

its is a standalone php script. it is how the helptoc has been built for a very long time ;)

avatar infograf768
infograf768 - comment - 3 Oct 2018

Therefore, as it can't be run, and I see no solution else for this issue, I am closing it.

avatar infograf768 infograf768 - change - 3 Oct 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-10-03 10:24:07
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 3 Oct 2018
avatar brianteeman
brianteeman - comment - 3 Oct 2018

of course it can be run

avatar infograf768
infograf768 - comment - 3 Oct 2018

If I run it then toc.son is empty. Therefore I guess #22474 (comment) was correct.
No use for this PR.

Add a Comment

Login with GitHub to post a comment