[#22462] - [4.0] Menu Type select button [a11y]
- Fixed in Code Base
- 2 Oct 2018
- Medium
- Build: 4.0-dev
- # 22462
- Diff
- brianteeman:menuselectbutton
User tests: Successful: Unsuccessful:
this Pr is for the menu type select button
Before this pr it was <a href= .... role=button
This is fine but it is a button, it is visually styled as a button and it is identified as a button to assistive technology.
However the default behaviour for a button is for it to be selected by either space or enter whereas the default behaviour for a link is for it only to be selected by the enter key.
This could be fixed by jvascript but far better to use the correct html and make the button really a button
There is no visual change - however if you use the tab key to navigate to the button you will be able to test that you can select the button and a modal opens by pressing the space bar as well as the enter key.
Please dont tell me about other areas of core that are also wrong - there are a lot - and I will submit discrete pr for them - as it will be easier to test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 22:03:03 |
| Closed_By | ⇒ | wilsonge |
Too quick - i need to change the href - pr coming
Thanks!