? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Oct 2018

this Pr is for the joomla xtd-editor buttons that appear BELOW the editor when not using tinymce

Before this pr they were <a href= .... role=button

This is fine but they are buttons, they are visually styled as buttons and they are identified as buttons to assistive technology.

However the default behaviour for a button is for it to be selected by either space or enter whereas the default behaviour for a link is for it only to be selected by the enter key.

This could be fixed by javascript but far better to use the correct html and make the button really a button

There is no visual change - however if you use the tab key to navigate to the buttons you will be able to test that you can select the button and a modal opens by pressing the space bar as well as the enter key.

Please dont tell me about other areas of core that are also wrong - there are a lot - and I will submit discrete pr for them - as it will be easier to test

avatar brianteeman brianteeman - open - 2 Oct 2018
avatar brianteeman brianteeman - change - 2 Oct 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2018
Category Layout
avatar brianteeman brianteeman - change - 2 Oct 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 2 Oct 2018

Thanks!

avatar wilsonge wilsonge - close - 2 Oct 2018
avatar wilsonge wilsonge - merge - 2 Oct 2018
avatar wilsonge wilsonge - change - 2 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-02 22:03:35
Closed_By wilsonge
avatar brianteeman
brianteeman - comment - 3 Oct 2018

Too quick - i need to change the href - pr coming

avatar brianteeman brianteeman - change - 5 Oct 2018
The description was changed
avatar brianteeman brianteeman - edited - 5 Oct 2018

Add a Comment

Login with GitHub to post a comment