? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Sep 2018

Replace hardcoded aria labels with language strings and alpha sort the language file

avatar brianteeman brianteeman - open - 28 Sep 2018
avatar brianteeman brianteeman - change - 28 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2018
Category Administration Language & Strings Modules
avatar infograf768
infograf768 - comment - 30 Sep 2018

I have tested this item ? unsuccessfully on a488fc7

For the reasons stated above.

Notepad (Windows) is not the compulsory reference tool for developers, specifically here when its way of sorting is ASCII based and not Standard Alphabetical Order.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22433.

avatar infograf768 infograf768 - test_item - 30 Sep 2018 - Tested unsuccessfully
avatar roland-d
roland-d - comment - 30 Sep 2018

For those using PhpStorm, you can install the String Manipulation plugin and it will sort Standard Alphabetical Order. You can find the plugin in the Plugins section of PhpStorm. Website of the plugin is here: https://plugins.jetbrains.com/plugin/2162-string-manipulation

avatar wilsonge
wilsonge - comment - 1 Oct 2018

Merging this because clearly having translated strings is better than untranslated strings. JM if you could do a PR fixing the order that would be fantastic. thankyou :)

avatar wilsonge wilsonge - change - 1 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-01 22:10:06
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 1 Oct 2018
avatar wilsonge wilsonge - merge - 1 Oct 2018
avatar brianteeman
brianteeman - comment - 2 Oct 2018

Thanks

Add a Comment

Login with GitHub to post a comment