? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
28 Sep 2018

Pull Request for Issue #19340 and #19624

Summary of Changes

Proposal to solve problems.

Testing Instructions

See issues.

Expected result

When you go to the link that is an alias then you will be redirected to the correct page.

Actual result

You remain on a page of the menu item alias.

avatar csthomas csthomas - open - 28 Sep 2018
avatar csthomas csthomas - change - 28 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2018
Category Libraries
avatar infograf768
infograf768 - comment - 4 Oct 2018

I have tested this item successfully on 8c5c907

It works fine here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432.
avatar infograf768 infograf768 - test_item - 4 Oct 2018 - Tested successfully
avatar ralain
ralain - comment - 4 Oct 2018

I have tested this item successfully on 8c5c907

Works as expected. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432.

avatar ralain ralain - test_item - 4 Oct 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 4 Oct 2018

@mbabker
Please check before merging that there are no unwanted consequences.

avatar Quy Quy - change - 4 Oct 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 4 Oct 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432.

avatar mbabker mbabker - change - 6 Oct 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-06 18:51:49
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 6 Oct 2018
avatar mbabker mbabker - merge - 6 Oct 2018
avatar sanderpotjer
sanderpotjer - comment - 5 Nov 2018

This change has unwanted consequences for us... An alias is not always necessarily a redirect. We are using aliases on purpose and don't want to have a 301 redirect for it (otherwise we would have created a redirect).

An example: we generate AMP-equivalents of pages by using the Alias menu-item. Thanks to the "Template Style" setting of the alias menu-item we can load a different (amp-focussed) template for that page. So e.g.:

  • website.com/article: menu-type article
  • website.com/amp/article: menu-type alias, with a different template selected and alias to "article".

Joomla 3.8.13:
website.com/amp/article is showing the article with the different (AMP) template

Joomla 3.9.0:
website.com/amp/article is redirected to website.com/article

If the "alias" should be considered as "redirect" after this patch, I don't see why we are still offering options for selecting the template style.

I do think we have two options here:
1: Revert this PR, and introduce a new System menu-type "Redirect" besides "Alias".
2: Add a new toggle option "Redirect": Yes/No, so you can select if the menu-item needs to be redirected or not.

avatar csthomas
csthomas - comment - 5 Nov 2018

I like point 2 more, but I'm not sure if the field label "Redirect" will be understandable.

avatar PatrickExact
PatrickExact - comment - 28 Nov 2018

This change affects our site as well. We are using a similar set-up as @sanderpotjer describes.

Option 2 should fix this change for sure.

avatar csthomas
csthomas - comment - 28 Nov 2018

I will try to prepare a new PR with option 2

avatar phproberto
phproberto - comment - 12 Dec 2018

This change broke our site.

Extensions using jQuery.ajax method like:

				jQuery.ajax({
					context:this,
					url: 'index.php?option=com_mycomponent&task=mycontroller.method&format=raw',
					dataType: 'json',
					data: {start: start.format(),end: end.format()},
					success: function(doc) {
						// Do something
					}
				});

Are now causing a redirection. It also happens with POST requests. I know using urls in javascript without using the routing system are not technically ok but they are actually used by extensions and this breaks things.

I had to "hack" core to revert this.

avatar csthomas
csthomas - comment - 12 Dec 2018

Proposed solution at #23278

Add a Comment

Login with GitHub to post a comment