Need a test on this one before we merge it. Just because I don't know the order of updates and stuff well enough (unsure if we need to load the jquery anyhow because we'll have the 3.x file still after an update has run). I think this should be fine. But until it's tested not sure enough

You mean testing an update from 3 to 4?

Because to test the full code a temp modification of the view file is needed.

What should we do here as it is unlikely that an upgrade will be tested in the close future?

@laoneo I will test it do you have short test instructions or is it just simulate the update process with pr installed first?

And could you resolve the conflict?

@wilsonge what exactly needs to be tested here? DIdin't get you full from your comment #22421 (comment)

On this specific page we might still have some old files loaded/non-updated files loaded on the upgrade. We might still have the old file and require jQuery or other things. Basically onupgrade is when we have the most bugs and generally I'd like to test that kinda thing as opposed to 'code review' merges which is what i do normally. because it's hard to predict exactly what happens on upgrade.

Actually to test all i need to do is to figure out how to generate the deleted files list in j4 from j3. if i can do that then we should be able to upgrade straight from 3.9.2 (which is what i think 4.0-dev is synced with right now) to 4.x via package upload in 3.9. Obviously however trying to figure out an automated way of doing that is proving hard - i tried thinking about this about two weeks ago but it's really tricky

But this site doesn't load any 3rd party code and the upgrade screen will be shown after a successful upgrade to j4. At this stage shouldn't be any legacy file for the next upgrade or?

@laoneo Can you fix the merge conflict so I can get this tested? How should this be tested?

But this site doesn't load any 3rd party code and the upgrade screen will be shown after a successful upgrade to j4. At this stage shouldn't be any legacy file for the next upgrade or?

On a short review this seams to be true the page we need to be very carefull with is: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/tmpl/update/default.php#L18

But I'm happy to assist on any upgrade tests to make sure this does not break things.

Conflicts fixed, @zero-24 and @roland-d would be nice to get this tested. Thanks for your help.

@laoneo I can test this but let me know how did you test it? Some test instructions are welcome :)

We need some sort of upgrade path and then the upgrade should be tested. If I got @zero-24 right, then he can help with it.

Tested:

Modify the version.php to a 3.9.x, fix database, choose custom URL for J Update with https://update.joomla.org/core/nightlies/next_major_list.xml and get the correct current version of J in the update checks.

With a Notice though:

Notice: Trying to get property 'version' of non-object in .../administrator/components/com_joomlaupdate/Model/UpdateModel.php on line 1357

Nevertheless, I clicked on Update and got

version was modified, database was updated OK. Looks like all went fine.

Thanks @infograf768!

Maybe solve the Notice too?Or shall I just set the Test as OK?

Better to do it in it's own pr as it is not related to this one.

Looks good to me:

I have tested this item ✅ successfully on 7702f1e

The Joomla Updater works as expected because it updated my site to the latest available Joomla version.

I have tested this item ✅ successfully on 7702f1e

Status "Ready To Commit".

Hmm i'm not sure whether this is a valid way of testing as pointing to the major_nighty Update server and this still ships the original files. I'm at the joomla day this weekend so i'm not sure whether i can build the package. It should also be tested with an package that include the change. As noted above i don't think this is relevant to this specific change but as George requested it we should double check this.

@jm can you please open an issue and tag me so i can take a look after my holidays?

@zero-24 RTC off?

Already asked @roland-d to test this case - yes remove RTC temporarily please. If both work then it's good to go

Roland has tested this successfully next to me. So merged. Thankyou @roland-d and of course @laoneo

I tested an update from 3.9.12 to 4.0.0-alpha12. Upgrade went fine. Just some small things I noticed

The template notice @wilsonge mentioned.

@roland-d can you open a PR for the duplicate ID? That ones new to me?

? Great!

still need an issue for the Notice?

Yes please! Just the duplicate ID one. Button sizing isn’t that important yet

I am speaking of
Notice: Trying to get property 'version' of non-object in .../administrator/components/com_joomlaupdate/Model/UpdateModel.php on line 1357
not the duplicate ID

Oh I totally missed that ?‍♂ yes please

#26293 cc @infograf768 i have done a PR to fix that notice in the installer :)