CSS should not be committed only scss please

first impressions very nice

Since applying this pr and running npm i I am missing various icons

Where the icon is missing - clicking on them gives a javascript error

Uncaught TypeError: Cannot read property '10' of null
    at Object.e.listItemTask (core.min.js?8be5a883767042ad65bf41d1f0f59c51:1)
    at HTMLAnchorElement.onclick (index.php?option=com_workflow&view=workflows&extension=com_content:436)
e.listItemTask @ core.min.js?8be5a883767042ad65bf41d1f0f59c51:1
onclick @ index.php?option=com_workflow&view=workflows&extension=com_content:436

Dropdown styling consistency

This is the current styling for the save menu with dropdown - note the icons are mono and the hover matches the button colour

The new dropdown for change status uses coloured icons and the hover highlight is a very pale grey which is hard to see

Since applying this pr and running npm i I am missing various icons

This is an issue in J! 4.0 in general, I think it could have to do something with: https://github.com/joomla/joomla-cms/pull/22349/files
@chmst is investigating atm.

@bembelimen, @brianteeman please test this: #22424 it should bring back the missing icons.

commented on the code to improvements needed to the js for accessibility

Thanks for the accessibility fixes. Just need the CSS to be fixed now and it's good to go

Hi @brianteeman I got an update from @lavipr for the dropdown, is this the requested solution?

I am not seeing any changes in the dropdown

It should look like that:

I will check again later when my pc finishes updating. I still think that the icons should be mono to match the mono icons in the save drop-down as shown in the image above but I am not a designer.

@lavipr is working on it.

@bembelimen please post when it is ready to test

Now :D sorry, only "not implemented change" is the language change...not sure about it, because we're at the article view...so they are all articles...

I thought it was ready so I tested it but still dont see any change in the dropdown

Mhh @brianteeman that's strange. I just checked the branch out again and did npm, the "hover" of the elements in the dropdown are now colorful + the icons are dark.

ok got it working now - I was in the wrong branch. It does what you say.

can you remind me what is the language issue please

This one: #22393 (review)

not sure about it, because we're at the article view...so they are all articles...

Thats true but presumably we will be using this dropdown throughout joomla so in those cases it would says something else.

Just a suggestion, but could the dropdown match the width of the parent button (as a minimum). Just my opinion, happy if it doesn't get implemented but I think it would look better. I also think it would look nice if it butted up with the edge of the border instead of going over the top, but I think that would cause some issue in terms of hovering on it potentially as you could be inbetween.

It could only be a minimum width as the text may be longer in non English lamguages

It could only be a minimum width as the text may be longer in non English lamguages

of course and a new option could potentially be added in the future.

@bembelimen can you make the dog happy and then it would be good to have a successful test here.

@laoneo the dog is happy now :)

I have tested this item ✅ successfully on aacb27f

I have tested this item successfully on the latest v4.0. dev. (After npm install).
With different combinations and different workflows - also featured and non-featured and checke_out articles. Everything works as expected and really like this.

I have tested this item ✅ successfully on aacb27f

I have tested this item successfully on the latest v4.0. dev. (After npm install).
With different combinations and different workflows - also featured and non-featured and checke_out articles. Everything works as expected and really like this.

I have tested this item ✅ successfully on aacb27f

Tested with different stages and transitions and the patch worked as expected, with some grey status and helpful messages.

I have tested this item ✅ successfully on aacb27f

Tested with different stages and transitions and the patch worked as expected, with some grey status and helpful messages.

RTC

RTC

Thanks

Thanks @wilsonge now we need this PR reopened to remove the unnecessary trash button: #21532