[#22367] - [Isis] Use native display sticky on toolbar
- Fixed in Code Base
- 2 Oct 2018
- Medium
- Build: staging
- # 22367
- Diff
- ciar4n:native-sticky
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Removes the sticky JS for the toolbar. Use native display sticky instead. The advantage is less/simpler code. The downside is the toolbar no longer sticks on browsers that dont support it (IE11).
Testing Instructions
Apply PR and check toolbar displays and sticks correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript |
| Labels |
Added:
?
|
||
Remove?
$offset = 20;
if ($displayHeader || !$statusFixed)
{
$offset = 30;
}
I have tested this item
Browser: Firefox
- go to "Extensions" -> "Plugins"
- select 50 items per page
- scroll down
Result: Toolbar disappear
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22367.
Looks like working here whatever the number of items per page.
Firefox Macintosh
If I scroll down below it disappears.
Windows Firefox 62.0.2
Thank you. Should be resolved with the latest commit.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22367.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22367.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22367.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-02 16:11:10 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Besides not being sticky, there are some display issues on IE11:
